Merged
Conversation
…-controller-tests
They require libvirt, even if it is not used
lukasfrank
approved these changes
Dec 18, 2025
opensovereigncloud-user
pushed a commit
to opensovereigncloud/libvirt-provider
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing server tests spawn an entire app, run against the IRI and verify by checking libvirt. These tests have been moved into the ./internal/server/integration folder. The new server tests just start the gRPC server, run against IRI, but only validate that corresponding store objects have been created.
The new controller tests only run the machine controller, run against the store and verify behavior by checking libvirt.
The tests can also be executed locally on Mac with a local libvirt installation.
Contributes to #541